Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Producer.withLogging1/Consumer.withLogging1 for binary compatibility #374

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add Producer.withLogging1/Consumer.withLogging1 for binary compatibility #374

merged 1 commit into from
Aug 24, 2023

Conversation

Z1kkurat
Copy link
Contributor

This is continuation of #372 for a logging-related method

@coveralls
Copy link

coveralls commented Aug 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5964089052

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 76.712%
Changes Missing Coverage Covered Lines Changed/Added Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Consumer.scala 0 1 0.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/Producer.scala 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerConverters.scala 1 95.08%
Totals Coverage Status
Change from base Build 5963748044: -0.1%
Covered Lines: 1367
Relevant Lines: 1782
💛 - Coveralls

@Z1kkurat Z1kkurat mentioned this pull request Aug 24, 2023
Merged
@Z1kkurat Z1kkurat merged commit e62d739 into master Aug 24, 2023
4 of 5 checks passed
@Z1kkurat Z1kkurat deleted the fix-compatibility branch August 24, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-surkov i-surkov i-surkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Z1kkurat @coveralls @i-surkov